[PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Roman Levenstein via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 11 17:41:19 PST 2016


swiftix added inline comments.

================
Comment at: include/clang/Basic/Attr.td:1394
@@ -1393,1 +1393,3 @@
 
+def PreserveMost : InheritableAttr {
+  let Spellings = [GNU<"preserve_most">];
----------------
aaron.ballman wrote:
> Do these attributes do anything on targets other than AArch64 and x86-64? If not, these should probably be inheriting from TargetSpecificAttr. (With tests confirming the behavior on other targets.)
These attributes are not target-specific, IMHO, and they would make sense for other targets as well.  But they are currently implemented only for AArch64 and x86-64.


http://reviews.llvm.org/D18025





More information about the cfe-commits mailing list