[PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

James Robinson via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 11 11:16:34 PST 2016


jamesr added a comment.

In http://reviews.llvm.org/D14731#373289, @EricWF wrote:

> My suggestion would be to make these annotations OFF by default and allow users to turn them on with a macro.


Our comments crossed streams but suggested the same thing :).  Any suggestions on a naming convention for the guard?  Also, would I set this macro unconditionally in LIT or is there a way to have it run tests both with and without the macro to ensure that when it is off code like the snippet you posted continues to build unmodified?


http://reviews.llvm.org/D14731





More information about the cfe-commits mailing list