[PATCH] D17986: [ASTMatchers] Existing matcher hasAnyArgument fixed and new matcher hasReturnValue added

[Balogh, Ádám via cfe-commits]

baloghadamsoftware added a comment.

In http://reviews.llvm.org/D17986#373134, @sbenza wrote:

> The reason we haven't fixed hasAnyArgument is that it can potentially break its users.
>  I'd prefer if you separated the fix from the addition.
>  That way we can revert the fix if needed.


I will separate it, OK. In the Clang there is one use case that I fixed, although it did not break the tests. Neither of the other "has..." checkers (except the general ones) ignore implicit casts and parenthesized expressions so this one should not do it either because it makes checking implicit casts impossible.

Matcher "hasReturnValue" is needed because "has" ignores all implicit casts and parenthesized expressions and we need to the check implicit casts. I will add a test and add it to the dynamic registry.


http://reviews.llvm.org/D17986