[PATCH] D18073: Add memory allocating functions

Alexander Riccio via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 23:04:25 PST 2016


ariccio added a comment.

In http://reviews.llvm.org/D18073#372697, @zaks.anna wrote:

> Since we are adding support for so many new APIs that are only available on Windows, could you please condition checking them only when we build for Windows. You probably can look and Language Options to figure that out.


Is there a problem with checking  them on linux/OSX also?

> Also, we should not duplicate all of our tests. Instead, we should add a single test per added API checking that it is modeling the operation we think it should model.


So should I dump the _dbg versions from the tests?


http://reviews.llvm.org/D18073





More information about the cfe-commits mailing list