[PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

Manman Ren via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 16:13:21 PST 2016


manmanren added inline comments.

================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:1234
@@ +1233,3 @@
+        if ((Spelling == "deprecated" || Spelling == "gnu::deprecated") &&
+            Variety != "GNU" && index == 1)
+          continue;
----------------
This does not look pretty. Maybe we can implement a function writeDeprecatedValue that can skip the second argument if it is empty?


http://reviews.llvm.org/D17865





More information about the cfe-commits mailing list