[PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

Roman Shirokiy via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 03:49:47 PST 2016


roman.shirokiy added a comment.

Hello!

Thanks for the feedback!

MSVC got its own runtime lib, so the function "AddRunTimeLibs" is not used anywhere in "visualstudio::Linker::Constructjob" i.e. "--rtlib" option is currently unused in MSVC environment (there is always a warning: argument unused during compilation').

  if (!Args.hasArg(options::OPT_nostdlib)) {
    AddRunTimeLibs(TC, TC.getDriver(), CmdArgs, Args);
  }

This change is necessary to actually handle "--rtlib" on MSVC, but I totally agree that test for "-nostdlib --rtlib=compiler-rt" case is missed.


http://reviews.llvm.org/D17453





More information about the cfe-commits mailing list