[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

[Chandler Carruth via cfe-commits]

chandlerc added a comment.

FYI, I'd lik eto hold off on submitting here until we're on the same page with Philip on the original LLVM review (http://reviews.llvm.org/D17946), but some comments on how this is working are below...


================
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+      OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+  _VMContext.setDiscardValueNames(true);
+#endif
+}
 
----------------
I'm surprised this isn't a driver-side NDEBUG default flip? Can this still be overridden with a flag?


http://reviews.llvm.org/D18024