[PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 3 09:56:22 PST 2016


sfantao added inline comments.

================
Comment at: lib/Sema/SemaOpenMP.cpp:9071
@@ +9070,3 @@
+/// 0 if it is inconclusive.
+static int CheckArrayExpressionReferToWholeSize(Sema &SemaRef, const Expr *E,
+                                                QualType BaseQTy) {
----------------
ABataev wrote:
> Don't use 'int' as a result of the functions, add enumeric and use it.
I changed this back to bool and reverted the sense given that I am only taking any action if something is proved NOT to be whole or unity.

================
Comment at: lib/Sema/SemaOpenMP.cpp:9127
@@ +9126,3 @@
+// if it is inconclusive.
+static int CheckArrayExpressionReferToUnitySize(Sema &SemaRef, const Expr *E,
+                                                QualType BaseQTy) {
----------------
ABataev wrote:
> Again, use enum as a return result
Using bool instead with reverted sense.


http://reviews.llvm.org/D17547





More information about the cfe-commits mailing list