[PATCH] D17722: Make sure SLocEntry is an expansion before using getExpansion() method in SourceManager.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 2 05:58:12 PST 2016

hokein abandoned this revision.
hokein added a comment.

In http://reviews.llvm.org/D17722#365267, @bkramer wrote:

> This doesn't have a test case. Also I don't understand why this is the correct fix. If someone is calling one of those method with a file SourceLocation (as opposed to a macro SourceLocation) they should stop doing that.

After a more deep investigation, I think the bug isn't related to SourceManger now. I'm closing this as in favor of http://reviews.llvm.org/D17805 .



More information about the cfe-commits mailing list