[PATCH] D17787: [Modules] Don't swallow errors when parsing optional attributes

Sean Silva via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 1 16:19:56 PST 2016

silvas added a comment.

makes sense. can you include a testcase? I assume we are forgetting some sort of diagnostic without this patch.

Also, if learning about Clang's modules, I would start with `addHeaderInclude` in lib/Frontend/FrontendActions.cpp. The module map stuff ultimately boils down to that (essentially, it textually forms a header which it then more-or-less compiles as a PCH; the submodule stuff is only relevant for setting Decl::Hidden and some extra checking when importing).


More information about the cfe-commits mailing list