[PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 1 13:47:02 PST 2016

thakis added inline comments.

Comment at: lib/Driver/Driver.cpp:2355
@@ +2354,3 @@
+    // Add pch if needed: "If you do not specify an extension as part of the
+    // path name, an extension of .pch is assumed. "
hans wrote:
> Maybe add .pch if needed?
It already does this in the next line (?)

Comment at: lib/Driver/Tools.cpp:431
@@ +430,3 @@
+          if (AI >= YcIndex)
+            continue;
+        } else {
hans wrote:
> I got confused here, because even if we don't "continue", we still won't hit the else if (A->getOption().matches(options::OPT_include)) branch below.
> But that branch is just dealing with implicit includes, we will still do the "Not translated, render as usual." step.
> Maybe add a comment to the "else if" branch below that that code is for non-CL style PCH includes?
Done I think, but I'm not sure I understood correctly what you were asking for.


More information about the cfe-commits mailing list