[PATCH] D17772: [clang-tidy]: string_view of temporary string

Jonathan Coe via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 1 10:27:52 PST 2016


Maybe config options could allow addition of owning and non-owning pairs?

I'd like to do that as an extension if this path is approved.

Jon

On 1 March 2016 at 12:29, David Blaikie <dblaikie at gmail.com> wrote:

> Any way to/would it be worth broadening this with an annotation or some
> such (or just a lost for now) of types that maintain references to their
> ctor params? (Eg: llvm arrayref, etc)
> On Mar 1, 2016 9:19 AM, "Jonathan B Coe via cfe-commits" <
> cfe-commits at lists.llvm.org> wrote:
>
>> jbcoe created this revision.
>> jbcoe added reviewers: aaron.ballman, alexfh.
>> jbcoe added a subscriber: cfe-commits.
>> jbcoe set the repository for this revision to rL LLVM.
>>
>> Find instances where a string_view is constructed from a temporary string
>> and replace the string_view with a string.
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D17772
>>
>> Files:
>>   clang-tidy/misc/CMakeLists.txt
>>   clang-tidy/misc/MiscTidyModule.cpp
>>   clang-tidy/misc/StringViewOfTemporaryCheck.cpp
>>   clang-tidy/misc/StringViewOfTemporaryCheck.h
>>   docs/clang-tidy/checks/list.rst
>>   docs/clang-tidy/checks/misc-string_view-of-temporary.rst
>>   test/clang-tidy/misc-string_view-of-temporary.cpp
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160301/ac017e08/attachment.html>


More information about the cfe-commits mailing list