[PATCH] D17390: Introduce -fembed-bitcode driver option

Steven Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 29 17:30:51 PST 2016

steven_wu added a comment.

Thanks for reviewing the patch. There is a problem in the test case (it only works on darwin). It is fixed in r262286.

Comment at: lib/Driver/Driver.cpp:1761
@@ -1747,1 +1760,3 @@
+    const ActionList *BackendInputs =
+      (EmbedBitcode ? Inputs : &(*Inputs)[0]->getInputs());
     // Compile job may be wrapped in CudaHostAction, extract it if
thakis wrote:
> Why is this change needed? If its needed, is the preceding comment out of date now?
The preceding comment is still true but this condition makes BackendInputs->begin() not always CompileJobAction. I have a cleaner way to handle this. I am rebasing and updating the patch.



More information about the cfe-commits mailing list