[PATCH] D17704: Added interfaces for code-formatting while applying replacements.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 29 03:43:39 PST 2016

klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.


Comment at: lib/Tooling/Core/Replacement.cpp:290
@@ +289,3 @@
+                                         const format::FormatStyle &Style) {
+  if (Replaces.empty()) return Replaces;
I'd return a default constructed Replacements() instead - I think that requires a bit less reasoning (as written currently, I'll need to reason that a copy is made to convince myself that this is correct).


More information about the cfe-commits mailing list