[PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 25 07:46:01 PST 2016


Anastasia added a comment.

I was just wondering with SPIRV coming these days, how long should we be supporting and maintaining previous SPIR versions. Might be worth clarifying that...


================
Comment at: lib/CodeGen/TargetInfo.cpp:7022
@@ -7021,1 +7021,3 @@
 
+class SPIRTargetCodeGenInfo : public TargetCodeGenInfo {
+public:
----------------
Could we please separate this from XCore code?

Add separate anonymous namespace for it and proper heading comment. See XCore above as an example.


http://reviews.llvm.org/D17596





More information about the cfe-commits mailing list