[PATCH] D17385: clang-format: [JS] single quote double quoted strings.

Martin Probst via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 24 07:51:32 PST 2016

mprobst marked an inline comment as done.

Comment at: lib/Format/Format.cpp:1579
@@ +1578,3 @@
+  // The width of the extra \ escapes is taken into account in getNextToken.
+  void requoteJSStringLiterals(tooling::Replacements &Replaces,
+                               FormatToken *Current) {
djasper wrote:
> What's the reason not to do this in FormatTokenLexer, ideally at the same time when increasing the length?
Done. I initially wanted to avoid having FormatTokenLexer generate Replacements, but this seems cleaner indeed.


More information about the cfe-commits mailing list