[PATCH] D17516: AMDGPU: Verify subtarget specific builtins

[Eric Christopher via cfe-commits]

echristo added inline comments.

================
Comment at: lib/Basic/Targets.cpp:1829
@@ -1820,2 +1828,3 @@
     }
+
     AddrSpaceMap = &AMDGPUAddrSpaceMap;
----------------
Extra whitespace.

================
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+  if (Has16BitInsts)
+    Features["16-bit-insts"] = true;
+
+  if (hasSMemRealTime)
+    Features["s-memrealtime"] = true;
+
----------------
This is typically more of the "move the cpu checks down here" area from what you'd have above. Also you're not calling the target independent version of initFeatureMap - is that done on purpose?


http://reviews.llvm.org/D17516