[PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 22 09:19:01 PST 2016

dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

Looks great, other than some non-standard indentation.

Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1886
@@ +1885,3 @@
+          svalBuilder.evalBinOp(state, op, resultVal, zeroVal,
+          svalBuilder.getConditionType());
+        DefinedSVal compareWithZeroVal = compareWithZero.castAs<DefinedSVal>();
Non-standard indentation here.


More information about the cfe-commits mailing list