[PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 22 08:21:54 PST 2016

Anastasia added a comment.

Yes, that's right. In this commit I assume parser has already accepted the blocks.

We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version. This way it's possible to enable them with earlier standards if whoever does it knows what it's needed for. We could give a warning in this case. What do you think?

However, I wouldn't block this patch on it, as I wouldn't commit them together anyways. But I am happy to prepare a separate patch.


More information about the cfe-commits mailing list