[PATCH] D17029: [AST] Implemented missing import for the Template type parameter and Injected Class Name in ASTImporter class.

Elisavet Sakellari via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 20 07:06:39 PST 2016


esakella added a comment.

In http://reviews.llvm.org/D17029#356428, @akyrtzi wrote:

> If I apply just the test changes without the rest of the changes, I don't see any failures, so I'm not sure these are effective tests.


This happens because also one of the changes is the new line 4304 which triggers the import of the template class definition , which in turn triggers the import of the other two elements.

If you only apply this change and the run the tests, then you see the respective error messages 'error: cannot import unsupported AST node InjectedClassName' and 'error: cannot import unsupported AST node TemplateTypeParm'.

I thought it would be better not to split and add this small change by itself, so I put them all together.


http://reviews.llvm.org/D17029





More information about the cfe-commits mailing list