r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

Hal Finkel via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 20 06:29:03 PST 2016



----- Original Message -----
> From: "Dimitry Andric via cfe-commits" <cfe-commits at lists.llvm.org>
> To: "Hans Wennborg" <hans at chromium.org>
> Cc: "Roman Divacky" <rdivacky at freebsd.org>, "cfe-commits" <cfe-commits at lists.llvm.org>
> Sent: Saturday, February 20, 2016 8:24:36 AM
> Subject: Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.
> 
> On 20 Feb 2016, at 09:31, Roman Divacky via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > 
> > Author: rdivacky
> > Date: Sat Feb 20 02:31:24 2016
> > New Revision: 261422
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=261422&view=rev
> > Log:
> > Fix handling of vaargs on PPC32 when going from regsave to
> > overflow.
> > 
> > It can happen that when we only have 1 more register left in the
> > regsave
> > area we need to store a value bigger than 1 register and therefore
> > we
> > go to the overflow area. In this case we have to leave the last
> > slot
> > in the regsave area unused and keep using overflow area. Do this
> > by storing a limit value to the used register counter in the
> > overflow block.
> > 
> > Issue diagnosed by and solution tested by Mark Millard!
> 
> Hans, this looks like a nice minor fix to have in 3.8.0.  Can we
> merge it, please?

Fine by me.

 -Hal

> 
> -Dimitry
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory


More information about the cfe-commits mailing list