[PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 17 11:03:12 PST 2016


rnk added a comment.

Thanks, but I don't think we should do this. There's already a lot of code out there (ffmpeg) that is already using clang its current form and it does stuff like this:

  #if defined(_MSC_VER) && !defined(__clang__)
  # define inline __inline
  // More MSVC compatibility hacks unnecessary with clang here...
  #endif

Any code using 'inline' as an identifier is going to have a hard time going forward. I think our current behavior is better for the majority of our users.


http://reviews.llvm.org/D17330





More information about the cfe-commits mailing list