[PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

Andrey Bokhanko via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 17 08:58:19 PST 2016


andreybokhanko added a comment.

In http://reviews.llvm.org/D17330#354730, @majnemer wrote:

> Why not just stick clang in C90 mode when targeting C if the -fms-compatibility-version is 18?
>
> We have similar code for the C++ mode in https://github.com/llvm-mirror/clang/blob/master/lib/Driver/Tools.cpp#l5069


David, thanks for looking into this!

MSVC18 doesn't support a set C standard; it adds some things from C99 as well. For example, it supports _Bool. So, I tried not to throw away baby along with bathwater and cause too much disruption.

OK -- will implement a driver fix that sets C90 for MSVC18 tomorrow and will update the patch.

Andrey


http://reviews.llvm.org/D17330





More information about the cfe-commits mailing list