[PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 15:41:03 PST 2016


rsmith added a comment.

If a patch is LGTM'd and some small change is requested at the same time, that typically means "LGTM once you make the following changes, which I trust you to make with no further pre-commit review". If you'd prefer more pre-commit review, of course, that's fine too.

In any case, this still LGTM, assuming it also includes the functional change itself (which is somehow missing from the latest revision here) =)


http://reviews.llvm.org/D15095





More information about the cfe-commits mailing list