r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Romanova, Katya via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 11 14:19:57 PST 2016


Sure. I’ll change it. Do you mind if I do it when I’m back from vacation (i.e. a couple of weeks from now)?
I will send a patch.
Thank you!
Katya.

From: Eric Christopher [mailto:echristo at gmail.com]
Sent: Wednesday, February 10, 2016 5:08 PM
To: Romanova, Katya; cfe-commits at lists.llvm.org
Subject: Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.


On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger <joerg at britannica.bec.de<mailto:joerg at britannica.bec.de>> wrote:
On Thu, Feb 11, 2016 at 12:18:49AM +0000, Eric Christopher via cfe-commits wrote:
> Mostly that you didn't mention it in your commit message.
>
> I'd rather prefer the rest of the file be changed to match the __ rather
> than the other way around :)

Depends. If it is a macro, not using __ is fine. If it is an inline
function, it *must* use the protected namespace, since an application can
#define a fancy junk here.

Yep. Which is why I'd prefer the rest of the file changed to match the __. I was just trying to get Katya to do it :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160211/812b0bed/attachment.html>


More information about the cfe-commits mailing list