[PATCH] D17146: [libcxx] locale portability refactor

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 11 11:20:55 PST 2016


mclow.lists added a comment.

I am very much in favor of cleaning up this part of libc++. 
Thanks for taking this on.

> I'm open to recommendations on ways to test this that are better than "Submit, watch build bots, revert as necessary".


My suggestion is to do this incrementally.
Implement the infrastructure bits, then move (say) Linux over to use the new bits.
Then (say) Mac OS X. Then FreeBSD. Then IBM. Then Windows.
Repeat until everyone's moved over; watching the testbots (and getting the people who committed support for each of these systems involved).
Then, when they're all moved, delete the old stuff.


http://reviews.llvm.org/D17146





More information about the cfe-commits mailing list