[PATCH] D17130: Debloat some headers

Craig Topper via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 23:51:18 PST 2016


craig.topper added a subscriber: craig.topper.
craig.topper added a comment.

What's complex about the SVal constructors?


================
Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143
@@ -144,3 +142,3 @@
   void addAbortedBlock(const ExplodedNode *node, const CFGBlock *block) {
-    blocksAborted.push_back(std::make_pair(block, node));
+    blocksAborted.emplace_back(block, node);
   }
----------------
I think previous discussions on the mail list have talked about only using emplace_back if the type isn't trivially copyable/moveable.


http://reviews.llvm.org/D17130





More information about the cfe-commits mailing list