[PATCH] D17043: Check that the result of a library call w/o side effects is used

[Sidney San Martín via cfe-commits]

> On Feb 10, 2016, at 8:05 PM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> 
> I'm not a big fan of this. Those calls are by the very definition
> harmless, so they aggrevate the existing problem of stupid annotation.

The issue is that the annotation's current diagnostic is pretty nonspecific and therefore not useful to programmers who don't know what it means in that specific case. Adding parameters to specify a specific, useful diagnostic (and maybe deprecating the argument-less use), or forking this into two more specific annotations, should resolve things.