[PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) {
+  MaybeParseGNUAttributes(Attrs);
----------------
pxli168 wrote:
> Anastasia wrote:
> > pxli168 wrote:
> > > I am wondering where should this function goes in, here or ParseDecl.cpp.
> > ParseGNUAttributes is in ParseDecl.cpp, but may be because it's generally applicable to Decls?
> > 
> > I am not aware of any rule here.
> Maybe we could ask richard for help?
I am thinking of leaving it here for now as we are almost done.

We can always do fixes later on!

================
Comment at: lib/Parse/ParseStmt.cpp:2220
@@ +2219,3 @@
+
+  if (Attrs.getList()->getName()->getName() != "opencl_unroll_hint")
+    return true;
----------------
pxli168 wrote:
> Using string is not very strict, can use AttributeList Kind to check that.
> 
> ```
> Attrs.getList()->getKind() != AttributeList::AT_OpenCLUnrollHint
> ```
ping!

================
Comment at: test/SemaOpenCL/unroll-hint.cl:1
@@ +1,2 @@
+//RUN: %clang_cc1 -O0 -fsyntax-only -verify %s
+
----------------
pxli168 wrote:
> I think one test case here is enough, since they all hint the same code.
ping!


http://reviews.llvm.org/D16686