[PATCH]: git-clang-format

Alexander Shukaev via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 8 09:28:00 PST 2016


On 02/08/2016 12:32 PM, Manuel Klimek wrote:
> I believe you forgot to add cfe-commits as subscriber on the patch.
>
> On Sun, Feb 7, 2016 at 12:51 PM Alexander Shukaev <
> clang at alexander.shukaev.name> wrote:
>
>> On 12/14/2015 10:03 PM, Alexander Shukaev wrote:
>>> On 12/11/2015 04:40 PM, Daniel Jasper wrote:
>>>> Please submit patches to clang-format to reviews.llvm.org. Also, any
>>>> change
>>>> no matter how easy it is to deduce from the code itself deserves a
>> proper
>>>> change description :-). Bullet points are fine.
>>>
>>> Thanks for the quick reply.  I've submitted the patch for review [1] as
>>> requested.  Just let me know if anything else is needed.
>>>
>>> Regards,
>>> Alexander
>>>
>>> [1] http://reviews.llvm.org/D15465
>>
>> Hello,
>>
>> I am wondering whether I can expect this patch to be reviewed and
>> included into the upcoming 3.8 release?  I didn't receive any feedback
>> ever since it was submitted.  Apologies, I don't want to annoy anybody
>> but seeing no reaction at all within a couple months feels rude.
>>
>> Kind regards,
>> Alexander
>>
>

Ah, I suspected something should be wrong with the submission...  Thanks 
for pointing this out.  Nevertheless, I'm sure that I've added key 
people as reviewers, so they should have had definitely received 
notifications about this patch...  I'm confused now.  Anyway, now I've 
added cfe-commits to subscribers.  I hope this patch still has a chance 
to hit 3.8.

Regards,
Alexander


More information about the cfe-commits mailing list