[PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

Duncan P. N. Exon Smith via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 6 15:02:29 PST 2016


dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.

Light review below, looks like great work.

I noticed the tests seem somewhat inconsistent about whether to
glue `&` to the type or use two spaces (i.e., ` & `).  Which one is
preferred in this codebase?  Or is it laissez-faire?

The rest of my comments are inline.


http://reviews.llvm.org/D16948





More information about the cfe-commits mailing list