[PATCH] D16792: unordered_map: Use __hash_table::__emplace_unique(), NFC

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 6 13:28:24 PST 2016


EricWF added a comment.

This is very subtly broken. The requirements in the standard for emplace are

[unord.req] Table 102

> a_eq.emplace(args)

>  Requires: : value_type shall be EmplaceConstructible into X from args.


Unfortunately __hash_table doesn't know that unordered_map has this "special" value_type, so it can't actually extract and construct the correct value_type from it. I'm going to change
this over the weekend.  Once I've done some prep work this patch should be ready to go.


http://reviews.llvm.org/D16792





More information about the cfe-commits mailing list