r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 5 11:06:48 PST 2016


Probably not (unless someone corrects me). In that case, it can wait
for the next release.

Thanks,
Hans

On Fri, Feb 5, 2016 at 11:02 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Is PR25804 a regression?
>
> ~Aaron
>
> On Fri, Feb 5, 2016 at 1:59 PM, Hans Wennborg via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>> It was requested that this be merged to 3.8 as it fixes PR25804.
>>
>> Manuel: does this look OK for the branch?
>>
>> Thanks,
>> Hans
>>
>> On Fri, Feb 5, 2016 at 10:29 AM, Samuel Benzaquen via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>>> Author: sbenza
>>> Date: Fri Feb  5 12:29:24 2016
>>> New Revision: 259898
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=259898&view=rev
>>> Log:
>>> [ASTMatchers] Allow hasName() to look through inline namespaces
>>>
>>> Summary:
>>> Allow hasName() to look through inline namespaces.
>>> This will fix the interaction between some clang-tidy checks and libc++.
>>>
>>> libc++ defines names in an inline namespace named std::<version_#>.
>>> When we try to match a name using hasName("std::xxx") it fails to match and the clang-tidy check does not work.
>>>
>>> Reviewers: klimek
>>>
>>> Subscribers: klimek, cfe-commits
>>>
>>> Differential Revision: http://reviews.llvm.org/D15506
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list