[PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Mats Petersson via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 5 09:48:18 PST 2016


Leporacanthicus added a subscriber: Leporacanthicus.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7684
@@ +7683,3 @@
+  "the __block storage type is not permitted">;
+
+def err_opencl_variadic_prototype_not_allowed : Error<
----------------
Is this blank line there for a reason, as there seem to be none above... 

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7704
@@ +7703,3 @@
+def err_opencl_invalid_block_declaration : Error<
+  "invalid block variable declaration - must be %select{const qualified|initialised}0">;
+def err_opencl_extern_block_declaration : Error<
----------------
US spelling is initialized - which I believe is standard for Clang?

================
Comment at: test/SemaOpenCL/invalid-blocks-cl20.cl:5
@@ +4,3 @@
+
+// All blocks declarations must be const qualified and initialised.
+void f1() {
----------------
US spelling will need to be fixed here too, if fixed above.


Repository:
  rL LLVM

http://reviews.llvm.org/D16928





More information about the cfe-commits mailing list