[PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

A couple of post-commit comments.


================
Comment at: clang-tools-extra/trunk/clang-tidy/google/GlobalNamesInHeadersCheck.h:24
@@ +23,3 @@
+///
+/// The check supports these options:
+///   - `HeaderFileExtensions`: a comma-separated list of filename extensions
----------------
BTW, this belongs to the user-facing doc, so please move this to the .rst file. Same for other checks.

================
Comment at: clang-tools-extra/trunk/clang-tidy/utils/HeaderFileExtensionsUtils.cpp:53
@@ +52,3 @@
+    StringRef Extension = Suffix.trim();
+    for (StringRef::const_iterator it = Extension.begin();
+         it != Extension.end(); ++it) {
----------------
BTW, you should be able to use a range-based for loop.


Repository:
  rL LLVM

http://reviews.llvm.org/D16113