[PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 4 11:40:20 PST 2016


ABataev added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:218
@@ -204,1 +217,3 @@
+  }
+  return;
 }
----------------
I think this must be removed

================
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+      Diags.Report(clang::diag::err_drv_omp_host_or_device_target_not_supported)
+          << TargetOpts.Triple << Opts.OpenMPIsDevice;
+      break;
----------------
OpenMPIsDevice is always false here. Do we really need it here?


http://reviews.llvm.org/D16784





More information about the cfe-commits mailing list