[PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:46
@@ +45,3 @@
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+                               HeaderFileExtensionsSet &HeaderFileExtensions,
+                               char delimiter) {
----------------
hokein wrote:
> alexfh wrote:
> > Actually, this could be changed to a more generic `parseStringSetOption` or something similar. Let's do this in a follow up.
> > 
> > But for now we need to change the output parameter type to llvm::SmallSetImpl<StringRef> to avoid hardcoding the small size template argument. The typedef is then not useful anymore.
> > But for now we need to change the output parameter type to llvm::SmallSetImpl<StringRef> to avoid hardcoding the small size template argument. The typedef is then not useful anymore.
> 
> I can't find `llvm::SmallSetImpl` or any similar `Set` without size template argument.
Hm, indeed SmallSet has no base class unlike SmallVector, for example. Ok, then seems good for now.


http://reviews.llvm.org/D16113