[PATCH] D12834: add gcc abi_tag support

Dmitry Polukhin via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 07:35:33 PST 2016


DmitryPolukhin added a comment.

I think Sema part should be exacted to separate patch and committed first after fixing Aaron's comments. Mangling part requires more work and much more tests. I'm still looking what actually GCC does and how it can be re-implemented in Clang without calling mangler twice.


================
Comment at: lib/Sema/SemaDeclAttr.cpp:4450
@@ +4449,3 @@
+static void handleAbiTagAttr(Sema &S, Decl *D,
+                             const AttributeList &Attr) {
+  const auto *NS = dyn_cast<NamespaceDecl>(D);
----------------
Nit, all args fits to single line and the whole function needs clang-format.


Repository:
  rL LLVM

http://reviews.llvm.org/D12834





More information about the cfe-commits mailing list