[PATCH] D14274: Add alloc_size attribute to clang

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 2 13:29:51 PST 2016


george.burgess.iv added inline comments.

================
Comment at: lib/Sema/SemaDeclAttr.cpp:737
@@ +736,3 @@
+                                    unsigned FuncParamNo, unsigned AttrArgNo) {
+  assert(Attr.getArg(AttrArgNo).is<Expr *>());
+  // FuncParamNo is base-1
----------------
aaron.ballman wrote:
> Can be replaced with assert(Attr.isArgExpr(AttrArgNo) && "expected expression argument");
Neat! Thanks.


http://reviews.llvm.org/D14274





More information about the cfe-commits mailing list