[PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

[Igor Chesnokov via cfe-commits]

ichesnokov added inline comments.

================
Comment at: test/CodeGenOpenCL/ternary-implicit-casts-fail.cl:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s
+// XFAIL: *
+
----------------
ichesnokov wrote:
> asl wrote:
> > ichesnokov wrote:
> > > asl wrote:
> > > > Don't do XFAIL tests - they will be "ok" regardless of the failure type. Make sure you're checking the exact error message, etc.
> > > Unable to use // expected-error {{}}.
> > > Compiler gives error: initializing '__local int *' with an expression of type 'void *' changes address space of pointer
> > > Using // expected-error {{initializing '__local int *' with an expression of type 'void *' changes address space of pointer}} does not work.
> > > Thus I used XFAIL.
> > This is either bug in expected-error stuff (which I honestly doubt) or you did something wrong.
> I'll send the patch to llvm-dev to find out what's the reason of expected-error fail.
It was my error: I forgot add -verify parameter.


http://reviews.llvm.org/D16682