[PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 17:57:51 PST 2016


rsmith added inline comments.

================
Comment at: include/clang/AST/DeclTemplate.h:374
@@ +373,3 @@
+  bool isConcept() const { return TemplatedDecl.getInt(); }
+  void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
----------------
I would prefer to not have a setter at all, but if it's awkward to pass this flag into the constructor, then a setter is fine (and I don't mind whether or not it takes a parameter). We should definitely not take a parameter and ignore it though.


http://reviews.llvm.org/D13357





More information about the cfe-commits mailing list