r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

[Hans Wennborg via cfe-commits]

On Mon, Feb 1, 2016 at 1:53 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg <hwennborg at google.com> wrote:
>> I don't think we have a specific code owner for OpenCL in Clang, which
>> means Richard is the owner.
>>
>> Richard, what do you think?
>
> Is there a reason we want to push this new feature into 3.8 rather
> than waiting for the next release?

Not from my end. Unless it's a low-cost merge (and it doesn't seem to
be, based on your comments), it seems this should just wait for 3.9.


>> On Wed, Jan 27, 2016 at 10:08 PM, xiuli pan <xiulipan at outlook.com> wrote:
>>> Hi hans,
>>>
>>> Request to merge it to release 38
>>>
>>> It adds Pipe BIFs to be used along with Pipe type committed earlier (in r257254).
>>>
>>> Thanks
>>> Xiuli
>>>
>>> -----Original Message-----
>>> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of Xiuli Pan via cfe-commits
>>> Sent: Tuesday, January 26, 2016 12:04 PM
>>> To: cfe-commits at lists.llvm.org
>>> Subject: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions
>>>
>>> Author: pxl
>>> Date: Mon Jan 25 22:03:48 2016
>>> New Revision: 258782
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=258782&view=rev
>>> Log:
>>> Recommit: R258773 [OpenCL] Pipe builtin functions
>>> Fix arc patch fuzz error.
>>> Summary:
>>> Support for the pipe built-in functions for OpenCL 2.0.
>>> The pipe builtin functions may have infinite kinds of element types, one approach
>>> would be to just generate calls that would always use generic types such as void*.
>>> This patch is based on bader's opencl support patch on SPIR-V branch.
>>>
>>> Reviewers: Anastasia, pekka.jaaskelainen
>>>
>>> Subscribers: keryell, bader, cfe-commits
>>>
>>> Differential Revision: http://reviews.llvm.org/D15914