[PATCH] D16526: Add hasRetValue narrowing matcher for returnStmt

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 09:33:30 PST 2016


aaron.ballman added a comment.

In http://reviews.llvm.org/D16526#340785, @LegalizeAdulthood wrote:

> In http://reviews.llvm.org/D16526#334938, @aaron.ballman wrote:
>
> > I'm of two minds on this [...]
>
>
> I just need a thumbs up/down on this.
>
> Thumbs down, I discard the review.
>
> Thumbs up, you take the patch.
>
> Patch by Richard Thomson.


I think the patch should be discarded. I appreciate the time you put into making the patch, however!


http://reviews.llvm.org/D16526





More information about the cfe-commits mailing list