[PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 08:37:01 PST 2016


alexfh added a comment.

Thank you for adding more test cases! Could you address one more comment in a follow-up, please?


================
Comment at: test/clang-tidy/readability-redundant-control-flow.cpp:193
@@ +192,3 @@
+// CHECK-FIXES-NEXT: {{^    return;$}}
+// CHECK-FIXES-NEXT: {{^ *}$}}
+
----------------
This test doesn't verify whether the second `return` is removed or not. Whatever the behavior is, it would be good to make it obvious in the test.


http://reviews.llvm.org/D16259





More information about the cfe-commits mailing list