[PATCH] D16708: Add a new attribute CFNoRelease.

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D16708#340359, @gottesmm wrote:

> I think that my response via email did not hit phabriactor. So sorry for the delay.


No worries!

> Yes there is a forthcoming patch for CodeGen which will place an attribute on the relevant functions. The attribute will be queried in the middle end optimizer. The reason why there has been a bit of a delay is I realized I wanted to talk to a few more people about this attribute internally.

> 

> We may want to expand its use to essentially mean "no-arc", i.e. this is a c function that uses pure c-code.

> 

> There are other possibilities as well so stay tuned.


Okay, I would recommend the future patch include that middle end component as well. It gives better context for the attribute side of things.


================
Comment at: include/clang/Basic/Attr.td:540
@@ +539,3 @@
+  let Subjects = SubjectList<[Function]>;
+  let Documentation = [Undocumented];
+}
----------------
gottesmm wrote:
> aaron.ballman wrote:
> > Please, no undocumented new attributes. You should modify AttrDocs.td and include that reference here.
> Ok. I was just following what was done in the surrounding code. I am fine with adding something to AttrDocs.td once we pin down exactly what we want.
> 
Yeah, the surrounding code was grandfathered in. It really should be documented as well. ;-)


http://reviews.llvm.org/D16708