r259355 - Remove the egregious PCHContainer layering hack that doesn't seem to be necessary anymore.

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 05:22:40 PST 2016


Author: d0k
Date: Mon Feb  1 07:22:39 2016
New Revision: 259355

URL: http://llvm.org/viewvc/llvm-project?rev=259355&view=rev
Log:
Remove the egregious PCHContainer layering hack that doesn't seem to be necessary anymore.

Modified:
    cfe/trunk/lib/Basic/FileManager.cpp
    cfe/trunk/lib/Frontend/PCHContainerOperations.cpp

Modified: cfe/trunk/lib/Basic/FileManager.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/FileManager.cpp?rev=259355&r1=259354&r2=259355&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/FileManager.cpp (original)
+++ cfe/trunk/lib/Basic/FileManager.cpp Mon Feb  1 07:22:39 2016
@@ -19,7 +19,6 @@
 
 #include "clang/Basic/FileManager.h"
 #include "clang/Basic/FileSystemStatCache.h"
-#include "clang/Frontend/PCHContainerOperations.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/Config/llvm-config.h"
 #include "llvm/ADT/STLExtras.h"
@@ -564,7 +563,3 @@ void FileManager::PrintStats() const {
 
   //llvm::errs() << PagesMapped << BytesOfPagesMapped << FSLookups;
 }
-
-// Virtual destructors for abstract base classes that need live in Basic.
-PCHContainerWriter::~PCHContainerWriter() {}
-PCHContainerReader::~PCHContainerReader() {}

Modified: cfe/trunk/lib/Frontend/PCHContainerOperations.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/PCHContainerOperations.cpp?rev=259355&r1=259354&r2=259355&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/PCHContainerOperations.cpp (original)
+++ cfe/trunk/lib/Frontend/PCHContainerOperations.cpp Mon Feb  1 07:22:39 2016
@@ -19,6 +19,9 @@
 
 using namespace clang;
 
+PCHContainerWriter::~PCHContainerWriter() {}
+PCHContainerReader::~PCHContainerReader() {}
+
 namespace {
 
 /// \brief A PCHContainerGenerator that writes out the PCH to a flat file.




More information about the cfe-commits mailing list