[PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 28 14:45:57 PST 2016

echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.

One inline nit then LGTM.


Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+  // Construct and fill the args buffer that we'll pass to vprintf.
+  llvm::Value* BufferPtr;
+  if (Args.size() <= 1) {
* on the wrong side ;)


More information about the cfe-commits mailing list