[PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation
Rong Xu via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 28 14:34:07 PST 2016
The previous patch was not good as it failed 58 tests that use
-fprofile-instr-generate as a cc1 option.
I can see two methods to solve this:
(1) we change all the 58 tests to use -fprofile-instrument=Clang option.
(2) Fall back to my previous patch: keep -fprofile-instr-generate as
the CC1 options and check it in Frontend/CompilerInvocation.cpp. (i.e.
The redundant else branch Sean was referring to). We have to do it
here because we cannot assume driver will append
-fprofile-instrument=Clang in the case the user uses
-fprofile-instr-generate as the cc1 option.
On Thu, Jan 28, 2016 at 12:04 PM, Rong Xu <xur at google.com> wrote:
> xur updated this revision to Diff 46303.
> xur added a comment.
> Integrated most recently comments/suggestions from David and Sean.
More information about the cfe-commits