[PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 28 11:34:18 PST 2016

jlebar added inline comments.

Comment at: lib/Driver/Driver.cpp:650
@@ -638,3 +649,3 @@
   SmallVector<std::pair<int, const Command *>, 4> FailingCommands;
-  C.ExecuteJobs(C.getJobs(), FailingCommands);
+  C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
> Why is StopOnFailure is false in this case? Shouldn't it obey command line options, too?
This function is called when the compiler has an internal error or crashes.  The jobs we're executing here are preprocessor jobs dumping debugging info.  I figured we should not stop on failure when outputting that info?


More information about the cfe-commits mailing list