[libcxx] r259046 - [libcxx] Work around for clang calling GAS after having already failed.

Daniel Sanders via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 28 05:57:54 PST 2016


Hi Hans,

Is it ok to merge this into 3.8? Eric Fiselier has already approved on the review.
________________________________________
From: cfe-commits [cfe-commits-bounces at lists.llvm.org] on behalf of Daniel Sanders via cfe-commits [cfe-commits at lists.llvm.org]
Sent: 28 January 2016 13:49
To: cfe-commits at lists.llvm.org
Subject: [libcxx] r259046 - [libcxx] Work around for clang calling GAS after having already failed.

Author: dsanders
Date: Thu Jan 28 07:49:33 2016
New Revision: 259046

URL: http://llvm.org/viewvc/llvm-project?rev=259046&view=rev
Log:
[libcxx] Work around for clang calling GAS after having already failed.

Summary:
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
release. The clang bug is currently being investigated. It seems that clang
does not stop after frontend errors when using -verify and -fno-integrated-as
(or when this is the default). This patch adds -fsyntax-only to prevent GAS
from being called, fixing the libcxx failures.

PR26277

Patch by Eric Fiselier

Reviewers: mclow.lists, hans, EricWF

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D16584

Modified:
    libcxx/trunk/test/libcxx/test/format.py

Modified: libcxx/trunk/test/libcxx/test/format.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/format.py?rev=259046&r1=259045&r2=259046&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/test/format.py (original)
+++ libcxx/trunk/test/libcxx/test/format.py Thu Jan 28 07:49:33 2016
@@ -161,7 +161,7 @@ class LibcxxTestFormat(object):
                        'expected-error', 'expected-no-diagnostics']
         use_verify = self.use_verify_for_fail and \
                      any([tag in contents for tag in verify_tags])
-        extra_flags = []
+        extra_flags = ['-fsyntax-only']
         if use_verify:
             extra_flags += ['-Xclang', '-verify',
                             '-Xclang', '-verify-ignore-unexpected=note']


_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list